netdev - RE: [PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61CC2BC414934749BD9F5BF3D5D940449874064D@ORSMSX112.amr.corp.intel.com>
Date:   Mon, 29 Jun 2020 17:18:46 +0000
From:   "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Mark Lee <Mark-MC.Lee@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "Heiner Kallweit" <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "Rob Herring" <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: RE: [PATCH v2 02/10] net: ethernet: ixgbe: don't call
 devm_mdiobus_free()

> -----Original Message-----
> From: Bartosz Golaszewski <brgl@...ev.pl>
> Sent: Monday, June 29, 2020 05:04
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; David S . Miller
> <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; John Crispin
> <john@...ozen.org>; Sean Wang <sean.wang@...iatek.com>; Mark Lee
> <Mark-MC.Lee@...iatek.com>; Matthias Brugger
> <matthias.bgg@...il.com>; Heiner Kallweit <hkallweit1@...il.com>; Andrew
> Lunn <andrew@...n.ch>; Florian Fainelli <f.fainelli@...il.com>; Russell King
> <linux@...linux.org.uk>; Rob Herring <robh+dt@...nel.org>; Frank Rowand
> <frowand.list@...il.com>
> Cc: linux-kernel@...r.kernel.org; netdev@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-mediatek@...ts.infradead.org;
> devicetree@...r.kernel.org; Bartosz Golaszewski
> <bgolaszewski@...libre.com>
> Subject: [PATCH v2 02/10] net: ethernet: ixgbe: don't call
> devm_mdiobus_free()
> 
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> The idea behind devres is that the release callbacks are called if probe fails. As
> we now check the return value of ixgbe_mii_bus_init(), we can drop the call
> devm_mdiobus_free() in error path as the release callback will be called
> automatically.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
 
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)