netdev - Re: [PATCH net] genetlink: take netlink table lock when (un)registering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51efec1d1c3c8cf0c8ae9b54939e59caf23db62e.camel@sipsolutions.net>
Date:   Tue, 30 Jun 2020 09:00:54 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     "stranche@...eaurora.org" <stranche@...eaurora.org>,
        Cong Wang <xiyou.wangcong@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Pravin B Shelar <pshelar@....org>,
        Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Subject: Re: [PATCH net] genetlink: take netlink table lock when
 (un)registering

On Mon, 2020-06-29 at 20:18 +0000, stranche@...eaurora.org wrote:
> 
> Thanks Cong. Yes, removing the genl_bind()/genl_unbind() functions
> eliminates the
> potential for this deadlock. Adding Johannes here to comment on removing
> these,
> as the family->mcast_bind() capability added by commit c380d9a7afff
> ("genetlink: pass multicast bind/unbind to families") would be lost.

I really don't remember what I/we added this for, but evidently we're
not using this now, neither in-tree nor anywhere I could find in new
not-yet-in-tree code (not a surprise, given the age, that would've
landed in the tree long ago).

So:

Acked-by: Johannes Berg <johannes.berg@...el.com>

johannes