netdev - Re: [PATCH net v2 2/8] net: ipip: implement header_ops->parse_protocol for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTScmNarsVr7htyyJPoyn1pn-Bjn=oX89domPDro5sT2qqA@mail.gmail.com>
Date:   Tue, 30 Jun 2020 12:02:01 -0400
From:   Willem de Bruijn <willemb@...gle.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Hans Wippel <ndev@...pl.net>
Subject: Re: [PATCH net v2 2/8] net: ipip: implement header_ops->parse_protocol
 for AF_PACKET

On Mon, Jun 29, 2020 at 9:06 PM Jason A. Donenfeld <Jason@...c4.com> wrote:
>
> Ipip uses skb->protocol to determine packet type, and bails out if it's
> not set. For AF_PACKET injection, we need to support its call chain of:
>
>     packet_sendmsg -> packet_snd -> packet_parse_headers ->
>       dev_parse_header_protocol -> parse_protocol
>
> Without a valid parse_protocol, this returns zero, and ipip rejects the
> skb. So, this wires up the ip_tunnel handler for layer 3 packets for
> that case.
>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

For all protocols, really. But it probably doesn't add much to repeat
this in each patch.