netdev - Re: [PATCH RFC net-next 04/13] net: phylink: ensure link is down when changing interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a919aaf1-346a-8bdc-6db5-0cc8f088c7cd@gmail.com>
Date:   Tue, 30 Jun 2020 11:32:59 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Ioana Ciornei <ioana.ciornei@....com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandru Marginean <alexandru.marginean@....com>,
        "michael@...le.cc" <michael@...le.cc>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH RFC net-next 04/13] net: phylink: ensure link is down when
 changing interface



On 6/30/2020 7:28 AM, Russell King wrote:
> The only PHYs that are used with phylink which change their interface
> are the BCM84881 and MV88X3310 family, both of which only change their
> interface modes on link-up events.  However, rather than relying upon
> this behaviour by the PHY, we should give a stronger guarantee when
> resolving that the link will be down whenever we change the interface
> mode.  This patch implements that stronger guarantee for resolve.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian