netdev - Re: [PATCH net] net: mvneta: fix use of state->speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200630.130150.323289712076556518.davem@davemloft.net>
Date:   Tue, 30 Jun 2020 13:01:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, thomas.petazzoni@...tlin.com,
        kuba@...nel.org, maxime.chevallier@...tlin.com
Subject: Re: [PATCH net] net: mvneta: fix use of state->speed

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Tue, 30 Jun 2020 11:04:40 +0100

> When support for short preambles was added, it incorrectly keyed its
> decision off state->speed instead of state->interface.  state->speed
> is not guaranteed to be correct for in-band modes, which can lead to
> short preambles being unexpectedly disabled.
> 
> Fix this by keying off the interface mode, which is the only way that
> mvneta can operate at 2.5Gbps.
> 
> Fixes: da58a931f248 ("net: mvneta: Add support for 2500Mbps SGMII")
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Applied and queued up for -stable, thanks.