netdev - Re: [PATCH net-next v2] tcp: call tcp_ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200630.134050.1991646116770207251.davem@davemloft.net>
Date:   Tue, 30 Jun 2020 13:40:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ysseung@...gle.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com, edumazet@...gle.com,
        soheil@...gle.com
Subject: Re: [PATCH net-next v2] tcp: call tcp_ack_tstamp() when not fully
 acked

From: Yousuk Seung <ysseung@...gle.com>
Date: Tue, 30 Jun 2020 09:49:33 -0700

> When skb is coalesced tcp_ack_tstamp() still needs to be called when not
> fully acked in tcp_clean_rtx_queue(), otherwise SCM_TSTAMP_ACK
> timestamps may never be fired. Since the original patch series had
> dependent commits, this patch fixes the issue instead of reverting by
> restoring calls to tcp_ack_tstamp() when skb is not fully acked.
> 
> Fixes: fdb7eb21ddd3 ("tcp: stamp SCM_TSTAMP_ACK later in tcp_clean_rtx_queue()")
> Signed-off-by: Yousuk Seung <ysseung@...gle.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>

Applied, thank you.