netdev - Re: [PATCH net 2/3] net: ipa: no checksum offload for SDM845 LAN RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bada706f-779b-9a53-0d92-c0b79f99f723@linaro.org>
Date:   Mon, 29 Jun 2020 20:02:35 -0500
From:   Alex Elder <elder@...aro.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, evgreen@...omium.org, subashab@...eaurora.org,
        cpratapa@...eaurora.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 2/3] net: ipa: no checksum offload for SDM845 LAN RX

On 6/29/20 7:10 PM, Jakub Kicinski wrote:
> On Mon, 29 Jun 2020 16:20:37 -0500 Alex Elder wrote:
>> The AP LAN RX endpoint should not have download checksum offload
>> enabled.
>>
>> The receive handler does properly accomodate the trailer that's
>> added by the hardware, but we ignore it.
>>
>> Signed-off-by: Alex Elder <elder@...aro.org>
> 
> For this net series - would you mind adding Fixes tags to each patch?

Yes.  That hasn't been my practice in the past; I guess I'll add
it to my checklist...

I will fix the spelling error in version 2.

					-Alex

> 
> Also checkpatch sayeth:
> 
> WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'?
> #10: 
> The receive handler does properly accomodate the trailer that's
>