netdev - Re: [PATCH net-next 1/3] net: ipa: always report GSI state errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b5baacc-3ae0-e801-1db7-d40dae560094@linaro.org>
Date:   Mon, 29 Jun 2020 20:03:26 -0500
From:   Alex Elder <elder@...aro.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, evgreen@...omium.org, subashab@...eaurora.org,
        cpratapa@...eaurora.org, bjorn.andersson@...aro.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] net: ipa: always report GSI state errors

On 6/29/20 7:09 PM, Jakub Kicinski wrote:
> On Mon, 29 Jun 2020 16:37:36 -0500 Alex Elder wrote:
>> We check the state of an event ring or channel both before and after
>> any GSI command issued that will change that state.  In most--but
>> not all--cases, if the state is something different than expected we
>> report an error message.
>>
>> Add error messages where missing, so that all unexpected states
>> provide information about what went wrong.  Drop the parentheses
>> around the state value shown in all cases.
>>
>> Signed-off-by: Alex Elder <elder@...aro.org>
> 
> nit:

Sorry about that.  I'll fix this and run checkpatch on v2.

Thanks for your quick review.
					-Alex

> CHECK: Alignment should match open parenthesis
> #105: FILE: drivers/net/ipa/gsi.c:1673:
> +		dev_warn(dev,
> +			"limiting to %u channels; hardware supports %u\n",
> 
> CHECK: Alignment should match open parenthesis
> #120: FILE: drivers/net/ipa/gsi.c:1685:
> +		dev_warn(dev,
> +			"limiting to %u event rings; hardware supports %u\n",
>