netdev - Re: [PATCH net-next] sfc: remove udp_tnl_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29d3564b-6bcc-9df7-f6a9-3d3867390e15@solarflare.com>
Date:   Wed, 1 Jul 2020 15:32:03 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <mhabets@...arflare.com>,
        <linux-net-drivers@...arflare.com>
Subject: Re: [PATCH net-next] sfc: remove udp_tnl_has_port

On 30/06/2020 23:50, Jakub Kicinski wrote:
> Nothing seems to have ever been calling this.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
That was intended to be used by encap offloads (TX csum and TSO), which
 we only recently realised we hadn't upstreamed the rest of; the
 udp_tnl_has_port method would be called from our ndo_features_check().
I'll try to get to upstreaming that support after ef100 is in, hopefully
 within this cycle, but if you don't want this dead code lying around in
 the meantime then have an
Acked-by: Edward Cree <ecree@...arflare.com>
 and I can revert it when I add the code that calls it.
(And don't worry, ef100 doesn't use ugly port-based offloads; it does
 proper CHECKSUM_PARTIAL and GSO_PARTIAL, so it won't have this stuff.)

-ed