netdev - Re: [PATCH 1/2] net: dsa: microchip: set the correct number of ports in dsa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a992ae4a-64b6-83b6-cbe5-0e8db39dcea6@microchip.com>
Date:   Wed, 1 Jul 2020 17:19:31 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Woojung.Huh@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <vivien.didelot@...il.com>, <f.fainelli@...il.com>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <Nicolas.Ferre@...rochip.com>
Subject: Re: [PATCH 1/2] net: dsa: microchip: set the correct number of ports
 in dsa_switch

On 01.07.2020 20:09, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Jul 01, 2020 at 07:51:27PM +0300, Codrin Ciubotariu wrote:
>> The number of ports is incorrectly set to the maximum available for a DSA
>> switch. Even if the extra ports are not used, this causes some functions
>> to be called later, like port_disable() and port_stp_state_set(). If the
>> driver doesn't check the port index, it will end up modifying unknown
>> registers.
>>
>> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
> 
> Hi Codrin
> 
> You don't indicate which tree this is for. net-next, or net?  It looks
> like it fixes a real issue, so it probably should be for net. But
> patches to net should be minimal. Is it possible to do the
> 
>          ds->num_ports = swdev->port_cnt;
> 
> without all the other changes? You can then have a refactoring patch
> in net-next.

This one should be for net. Ok then, I will send a simpler version of 
this patch for net, just to fix the issue and another one like this one 
for net-next.

Thanks and best regards,
Codrin

> 
> Thanks
>          Andrew
>