lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 1 Jul 2020 10:46:09 -0700
From:   Alexei Starovoitov <>
To:     Masahiro Yamada <>
Cc:     Alexei Starovoitov <>,,,,
        Michal Kubecek <>,, Andrii Nakryiko <>,
        Daniel Borkmann <>,
        "David S. Miller" <>,
        Jakub Kicinski <>,
        John Fastabend <>,
        KP Singh <>,
        Martin KaFai Lau <>,
        Sam Ravnborg <>,
        Song Liu <>,
        Valdis Kl ē tnieks <>,
        Yonghong Song <>
Subject: Re: [PATCH] bpfilter: allow to build bpfilter_umh as a module
 without static library

On Wed, Jul 01, 2020 at 06:26:44PM +0900, Masahiro Yamada wrote:
> Originally, bpfilter_umh was linked with -static only when
> Commit 8a2cc0505cc4 ("bpfilter: use 'userprogs' syntax to build
> bpfilter_umh") silently, accidentally dropped the CONFIG_BPFILTER_UMH=y
> test in the Makefile. Revive it in order to link it dynamically when
> Since commit b1183b6dca3e ("bpfilter: check if $(CC) can link static
> libc in Kconfig"), the compiler must be capable of static linking to
> enable CONFIG_BPFILTER_UMH, but it requires more than needed.
> To loosen the compiler requirement, I changed the dependency as follows:
>     depends on CC_CAN_LINK
>     depends on m || CC_CAN_LINK_STATIC
> to 'm' or 'n'.
> In theory, CONFIG_CC_CAN_LINK is not required for CONFIG_BPFILTER_UMH=y,
> but I did not come up with a good way to describe it.
> Fixes: 8a2cc0505cc4 ("bpfilter: use 'userprogs' syntax to build bpfilter_umh")
> Reported-by: Michal Kubecek <>
> Signed-off-by: Masahiro Yamada <>

Do you mind I'll take it into bpf-next tree?
Eric is working on a bunch of patches in this area. I'll take his set
into bpf-next as well and then can apply this patch.
Just to make sure there are no conflicts.

Powered by blists - more mailing lists