netdev - Re: [PATCH net] ip: Fix SO_MARK in RST, ACK and ICMP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Jul 2020 14:58:01 -0700
From:   Martin KaFai Lau <kafai@...com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] ip: Fix SO_MARK in RST, ACK and ICMP packets

On Wed, Jul 01, 2020 at 04:00:06PM -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> When no full socket is available, skbs are sent over a per-netns
> control socket. Its sk_mark is temporarily adjusted to match that
> of the real (request or timewait) socket or to reflect an incoming
> skb, so that the outgoing skb inherits this in __ip_make_skb.
> 
> Introduction of the socket cookie mark field broke this. Now the
> skb is set through the cookie and cork:
> 
> <caller>		# init sockc.mark from sk_mark or cmsg
> ip_append_data
>   ip_setup_cork		# convert sockc.mark to cork mark
> ip_push_pending_frames
>   ip_finish_skb
>     __ip_make_skb	# set skb->mark to cork mark
> 
> But I missed these special control sockets. Update all callers of
> __ip(6)_make_skb that were originally missed.
Reviewed-by: Martin KaFai Lau <kafai@...com>