netdev - Re: [PATCH bpf-next] tools/bpftool: turn off -Wnested-externs warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73e6534d-dc3c-7ecf-f10f-218707c6bb2a@iogearbox.net>
Date:   Thu, 2 Jul 2020 00:23:09 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com
Cc:     andrii.nakryiko@...il.com, kernel-team@...com
Subject: Re: [PATCH bpf-next] tools/bpftool: turn off -Wnested-externs warning

On 7/1/20 11:28 PM, Andrii Nakryiko wrote:
> Turn off -Wnested-externs to avoid annoying warnings in BUILD_BUG_ON macro when
> compiling bpftool:
> 
> In file included from /data/users/andriin/linux/tools/include/linux/build_bug.h:5,
>                   from /data/users/andriin/linux/tools/include/linux/kernel.h:8,
>                   from /data/users/andriin/linux/kernel/bpf/disasm.h:10,
>                   from /data/users/andriin/linux/kernel/bpf/disasm.c:8:
> /data/users/andriin/linux/kernel/bpf/disasm.c: In function ‘__func_get_name’:
> /data/users/andriin/linux/tools/include/linux/compiler.h:37:38: warning: nested extern declaration of ‘__compiletime_assert_0’ [-Wnested-externs]
>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                        ^~~~~~~~~~~~~~~~~~~~~
> /data/users/andriin/linux/tools/include/linux/compiler.h:16:15: note: in definition of macro ‘__compiletime_assert’
>     extern void prefix ## suffix(void) __compiletime_error(msg); \
>                 ^~~~~~
> /data/users/andriin/linux/tools/include/linux/compiler.h:37:2: note: in expansion of macro ‘_compiletime_assert’
>    _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>    ^~~~~~~~~~~~~~~~~~~
> /data/users/andriin/linux/tools/include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                       ^~~~~~~~~~~~~~~~~~
> /data/users/andriin/linux/tools/include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
>    BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
>    ^~~~~~~~~~~~~~~~
> /data/users/andriin/linux/kernel/bpf/disasm.c:20:2: note: in expansion of macro ‘BUILD_BUG_ON’
>    BUILD_BUG_ON(ARRAY_SIZE(func_id_str) != __BPF_FUNC_MAX_ID);
>    ^~~~~~~~~~~~
> 
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Lgtm, thanks for fixing, applied!