lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 1 Jul 2020 15:56:21 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Chris Healy <cphealy@...il.com>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [PATCH net-next v4 03/10] net: ethtool: netlink: Add support
 for triggering a cable test

On Sun, 10 May 2020 21:12:33 +0200 Andrew Lunn wrote:
> diff --git a/net/Kconfig b/net/Kconfig
> index c5ba2d180c43..5c524c6ee75d 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -455,6 +455,7 @@ config FAILOVER
>  config ETHTOOL_NETLINK
>  	bool "Netlink interface for ethtool"
>  	default y
> +	depends on PHYLIB=y || PHYLIB=n
>  	help
>  	  An alternative userspace interface for ethtool based on generic
>  	  netlink. It provides better extensibility and some new features,

Since ETHTOOL_NETLINK is a bool we end up not enabling it on
allmodconfig builds, (PHYLIB=m so ETHTOOL_NETLINK dependency 
can't be met) - which is v scary for build testing.

Is there a way we can change this dependency? Some REACHABLE shenanigans?

Or since there are just two callbacks maybe phylib can "tell" ethtool
core the pointers to call when it loads?

Powered by blists - more mailing lists