netdev - Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a205bada-8879-0dfd-c3ed-53fe9cef6449@ucloud.cn>
Date:   Wed, 1 Jul 2020 16:17:49 +0800
From:   wenxu <wenxu@...oud.cn>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Paul Blakey <paulb@...lanox.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after
 defrag in act_ct


On 7/1/2020 2:21 PM, wenxu wrote:
> On 7/1/2020 2:12 PM, Cong Wang wrote:
>> On Tue, Jun 30, 2020 at 11:03 PM wenxu <wenxu@...oud.cn> wrote:
>>> Only forward packet case need do fragment again and there is no need do defrag explicit.
>> Same question: why act_mirred? You have to explain why act_mirred
>> has the responsibility to do this job.
> The fragment behavior only depends on the mtu of the device sent in act_mirred. Only in
>
> the act_mirred can decides whether do the fragment or not.

Hi cong,


I still think this should be resolved in the act_mirred.  Maybe it is not matter with a "responsibility"

Did you have some other suggestion to solve this problem?


BR

wenxu

>