netdev - Re: [PATCH 1/1] mvpp2: xdp ethtool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFnufp0HTx0gguqerkRq2NLjijVXsZFh41b9wVX5jMDmfkvX-g@mail.gmail.com>
Date:   Thu, 2 Jul 2020 15:52:51 +0200
From:   Matteo Croce <mcroce@...ux.microsoft.com>
To:     David Miller <davem@...emloft.net>
Cc:     Sven Auhagen <sven.auhagen@...eatech.de>, netdev@...r.kernel.org,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Stefan Chulski <stefanc@...vell.com>,
        Marcin Wojtas <mw@...ihalf.com>, maxime.chevallier@...tlin.com,
        antoine.tenart@...tlin.com, thomas.petazzoni@...tlin.com
Subject: Re: [PATCH 1/1] mvpp2: xdp ethtool stats

Hi all,

Sven agreed to add the v2 of this patch to the series it depends on,
please drop this one.
I'm sending a v2 of the series soon.

Thanks,

On Wed, Jul 1, 2020 at 9:48 PM David Miller <davem@...emloft.net> wrote:
>
> From: Sven Auhagen <sven.auhagen@...eatech.de>
> Date: Wed, 1 Jul 2020 17:30:44 +0200
>
> >  static void mvpp2_read_stats(struct mvpp2_port *port)
> >  {
> >       u64 *pstats;
> > +     const struct mvpp2_ethtool_counter *s;
> > +     struct mvpp2_pcpu_stats xdp_stats = {};
> >       int i, q;
>
> Reverse christmas tree ordering here, please.
> > @@ -3166,6 +3271,7 @@
> >              struct xdp_frame **frames, u32 flags)
> >  {
> >       struct mvpp2_port *port = netdev_priv(dev);
> > +     struct mvpp2_pcpu_stats *stats = this_cpu_ptr(port->stats);
> >       int i, nxmit_byte = 0, nxmit = num_frame;
> >       u32 ret;
> >       u16 txq_id;
>
> Likewise.
>
> > @@ -3258,11 +3374,10 @@
> >       enum dma_data_direction dma_dir;
> >       struct bpf_prog *xdp_prog;
> >       struct xdp_buff xdp;
> > +     struct mvpp2_pcpu_stats ps = {};
> >       int rx_received;
> >       int rx_done = 0;
> >       u32 xdp_ret = 0;
> > -     u32 rcvd_pkts = 0;
> > -     u32 rcvd_bytes = 0;
>
> Likewise.
>


-- 
per aspera ad upstream