netdev - Re: [PATCH v1 2/2] qlcninc: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP+cEONGianqeie9HsVqVm6=LwKn_caF285U=vpdha0-+8B-ZA@mail.gmail.com>
Date:   Thu, 2 Jul 2020 22:32:21 +0530
From:   Vaibhav Gupta <vaibhavgupta40@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Bjorn Helgaas <helgaas@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Bjorn Helgaas <bjorn@...gaas.com>,
        Vaibhav Gupta <vaibhav.varodek@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Manish Chopra <manishc@...vell.com>,
        Rahul Verma <rahulv@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
        Shahed Shaikh <shshaikh@...vell.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v1 2/2] qlcninc: use generic power management

On Thu, Jul 2, 2020 at 10:06 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu,  2 Jul 2020 12:06:32 +0530 Vaibhav Gupta wrote:
> > With legacy PM, drivers themselves were responsible for managing the
> > device's power states and takes care of register states. And they use PCI
> > helper functions to do it.
> >
> > After upgrading to the generic structure, PCI core will take care of
> > required tasks and drivers should do only device-specific operations.
> >
> > .suspend() calls __qlcnic_shutdown, which then calls qlcnic_82xx_shutdown;
> > .resume()  calls __qlcnic_resume,   which then calls qlcnic_82xx_resume;
> >
> > Both ...82xx..() are define in
> > drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c and are used only in
> > drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c.
> >
> > Hence upgrade them and remove PCI function calls, like pci_save_state() and
> > pci_enable_wake(), inside them
> >
> > Compile-tested only.
> >
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>
>
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c: In function ‘qlcnic_82xx_shutdown’:
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c:1652:6: warning: unused variable ‘retval’ [-Wunused-variable]
>  1652 |  int retval;
>       |      ^~~~~~
Fixed in v2.
Thanks!

--Vaibhav Gupta