netdev - Re: [PATCH net-next 5/7] devlink: Add devlink health port reporters API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7b0bf0f-6e9c-6894-c6e8-dde4c5d3c4a7@mellanox.com>
Date:   Thu, 2 Jul 2020 20:48:00 +0300
From:   Moshe Shemesh <moshe@...lanox.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vladyslav Tarasiuk <vladyslavt@...lanox.com>
Subject: Re: [PATCH net-next 5/7] devlink: Add devlink health port reporters
 API


On 7/2/2020 7:40 PM, Jakub Kicinski wrote:
> On Thu,  2 Jul 2020 18:08:11 +0300 Moshe Shemesh wrote:
>> From: Vladyslav Tarasiuk <vladyslavt@...lanox.com>
>>
>> In order to use new devlink port health reporters infrastructure, add
>> corresponding constructor and destructor functions.
>>
>> Signed-off-by: Vladyslav Tarasiuk <vladyslavt@...lanox.com>
>> Reviewed-by: Moshe Shemesh <moshe@...lanox.com>
>> Reviewed-by: Jiri Pirko <jiri@...lanox.com>
> net/core/devlink.c:5361: warning: Function parameter or member 'port' not described in 'devlink_port_health_reporter_create'
> net/core/devlink.c:5361: warning: Excess function parameter 'devlink_port' description in 'devlink_port_health_reporter_create'
> net/core/devlink.c:5462: warning: Excess function parameter 'port' description in 'devlink_port_health_reporter_destroy'


I will resend with a fix. Thanks.