| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202007030459.1cWIhwno%lkp@intel.com>
Date: Fri, 3 Jul 2020 04:46:15 +0800
From: kernel test robot <lkp@...el.com>
To: Sudarsana Reddy Kalluru <skalluru@...vell.com>, davem@...emloft.net
Cc: kbuild-all@...ts.01.org, netdev@...r.kernel.org,
aelior@...vell.com, irusskikh@...vell.com, mkalderon@...vell.com
Subject: Re: [PATCH net-next 3/4] bnx2x: Add support for idlechk tests.
Hi Sudarsana,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Sudarsana-Reddy-Kalluru/bnx2x-Perform-IdleChk-dump/20200702-221259
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 23212a70077311396cda2823d627317c25e6e5d1
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
In file included from arch/arm/include/asm/irqflags.h:7,
from include/linux/irqflags.h:16,
from arch/arm/include/asm/bitops.h:28,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c:2:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c: In function 'bnx2x_idle_chk7':
>> arch/arm/include/asm/ptrace.h:112:23: error: expected identifier before '(' token
112 | #define predicate(x) ((x) & 0xf0000000)
| ^
>> drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c:3021:12: note: in expansion of macro 'predicate'
3021 | if (rec->predicate(&rec->pred_args)) {
| ^~~~~~~~~
drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c: In function 'bnx2x_idle_chk':
>> arch/arm/include/asm/ptrace.h:112:23: error: expected identifier before '(' token
112 | #define predicate(x) ((x) & 0xf0000000)
| ^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c:3075:12: note: in expansion of macro 'predicate'
3075 | if (rec.predicate(&rec.pred_args)) {
| ^~~~~~~~~
>> arch/arm/include/asm/ptrace.h:112:23: error: expected identifier before '(' token
112 | #define predicate(x) ((x) & 0xf0000000)
| ^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c:3090:13: note: in expansion of macro 'predicate'
3090 | if (rec.predicate(&rec.pred_args)) {
| ^~~~~~~~~
>> arch/arm/include/asm/ptrace.h:112:23: error: expected identifier before '(' token
112 | #define predicate(x) ((x) & 0xf0000000)
| ^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c:3106:12: note: in expansion of macro 'predicate'
3106 | if (rec.predicate(&rec.pred_args)) {
| ^~~~~~~~~
>> arch/arm/include/asm/ptrace.h:112:23: error: expected identifier before '(' token
112 | #define predicate(x) ((x) & 0xf0000000)
| ^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c:3122:13: note: in expansion of macro 'predicate'
3122 | if (rec.predicate(&rec.pred_args)) {
| ^~~~~~~~~
>> arch/arm/include/asm/ptrace.h:112:23: error: expected identifier before '(' token
112 | #define predicate(x) ((x) & 0xf0000000)
| ^
drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c:3142:13: note: in expansion of macro 'predicate'
3142 | if (rec.predicate(&rec.pred_args)) {
| ^~~~~~~~~
In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c:4:
At top level:
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h:2436:18: warning: 'dmae_reg_go_c' defined but not used [-Wunused-const-variable=]
2436 | static const u32 dmae_reg_go_c[] = {
| ^~~~~~~~~~~~~
vim +/predicate +3021 drivers/net/ethernet/broadcom/bnx2x/bnx2x_self_test.c
2986
2987 /* specific test for cfc info ram and cid cam */
2988 static void bnx2x_idle_chk7(struct bnx2x *bp,
2989 struct st_record *rec, char *message)
2990 {
2991 int i;
2992
2993 /* iterate through lcids */
2994 for (i = 0; i < rec->loop; i++) {
2995 /* make sure cam entry is valid (bit 0) */
2996 if ((REG_RD(bp, (rec->reg2 + i * 4)) & 0x1) != 0x1)
2997 continue;
2998
2999 /* get connection type (multiple reads due to widebus) */
3000 REG_RD(bp, (rec->reg1 + i * rec->incr));
3001 REG_RD(bp, (rec->reg1 + i * rec->incr + 4));
3002 rec->pred_args.val1 =
3003 REG_RD(bp, (rec->reg1 + i * rec->incr + 8));
3004 REG_RD(bp, (rec->reg1 + i * rec->incr + 12));
3005
3006 /* obtain connection type */
3007 if (is_e1 || is_e1h) {
3008 /* E1 E1H (bits 4..7) */
3009 rec->pred_args.val1 &= 0x78;
3010 rec->pred_args.val1 >>= 3;
3011 } else {
3012 /* E2 E3A0 E3B0 (bits 26..29) */
3013 rec->pred_args.val1 &= 0x1E000000;
3014 rec->pred_args.val1 >>= 25;
3015 }
3016
3017 /* get activity counter value */
3018 rec->pred_args.val2 = REG_RD(bp, rec->reg3 + i * 4);
3019
3020 /* validate ac value is legal for con_type at idle state */
> 3021 if (rec->predicate(&rec->pred_args)) {
3022 snprintf(message, MAX_FAIL_MSG,
3023 "%s. Values are 0x%x 0x%x\n", rec->fail_msg,
3024 rec->pred_args.val1, rec->pred_args.val2);
3025 bnx2x_self_test_log(bp, rec->severity, message);
3026 }
3027 }
3028 }
3029
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (75673 bytes)
Powered by blists - more mailing lists