netdev - Re: [PATCH net] net: dsa: microchip: set the correct number of ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200702.142742.455023767824311035.davem@davemloft.net>
Date:   Thu, 02 Jul 2020 14:27:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     codrin.ciubotariu@...rochip.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com,
        kuba@...nel.org
Subject: Re: [PATCH net] net: dsa: microchip: set the correct number of
 ports

From: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
Date: Thu, 2 Jul 2020 12:44:50 +0300

> The number of ports is incorrectly set to the maximum available for a DSA
> switch. Even if the extra ports are not used, this causes some functions
> to be called later, like port_disable() and port_stp_state_set(). If the
> driver doesn't check the port index, it will end up modifying unknown
> registers.
> 
> Fixes: b987e98e50ab ("dsa: add DSA switch driver for Microchip KSZ9477")
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>

Applied and queued up for -stable, thanks.