netdev - Re: [PATCH net-next v2 5/9] devlink: Add a new devlink port lanes attribute and pass to netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83d5c1e5-6236-ad06-57b7-811f60550e85@mellanox.com>
Date:   Thu, 2 Jul 2020 10:57:30 +0300
From:   Danielle Ratson <danieller@...lanox.com>
To:     Jakub Kicinski <kuba@...nel.org>, Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        michael.chan@...adcom.com, jeffrey.t.kirsher@...el.com,
        saeedm@...lanox.com, leon@...nel.org, jiri@...lanox.com,
        snelson@...sando.io, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, mlxsw@...lanox.com,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next v2 5/9] devlink: Add a new devlink port lanes
 attribute and pass to netlink

On 7/1/2020 9:54 PM, Jakub Kicinski wrote:
> On Wed,  1 Jul 2020 17:32:47 +0300 Ido Schimmel wrote:
>> diff --git a/include/net/devlink.h b/include/net/devlink.h
>> index 8f9db991192d..91752b79bb29 100644
>> --- a/include/net/devlink.h
>> +++ b/include/net/devlink.h
>> @@ -68,10 +68,13 @@ struct devlink_port_pci_vf_attrs {
>>   * struct devlink_port_attrs - devlink port object
>>   * @flavour: flavour of the port
>>   * @split: indicates if this is split port
>> + * @lanes: maximum number of lanes the port supports.
>> + *	   0 value is not passed to netlink and valid number is a power of 2.
> Why power of two? what about 100G R10?


Missed that, thanks.


>
>>   * @switch_id: if the port is part of switch, this is buffer with ID, otherwise this is NULL
>>   */
>>  struct devlink_port_attrs {
>>  	u8 split:1;
>> +	u32 lanes;
>>  	enum devlink_port_flavour flavour;
>>  	struct netdev_phys_item_id switch_id;
>>  	union {