netdev - Re: [PATCH net-next 03/15] sfc_ef100: skeleton EF100 PF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200703104319.4fcb6f9c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 3 Jul 2020 10:43:19 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 03/15] sfc_ef100: skeleton EF100 PF driver

On Fri, 3 Jul 2020 16:31:33 +0100 Edward Cree wrote:
> No TX or RX path, no MCDI, not even an ifup/down handler.
> Besides stubs, the bulk of the patch deals with reading the Xilinx
>  extended PCIe capability, which tells us where to find our BAR.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Warnings:

drivers/net/ethernet/sfc/ef100_netdev.c:31:6: warning: symbol 'efx_separate_tx_channels' was not declared. Should it be static?
drivers/net/ethernet/sfc/ef100_netdev.c:45:13: warning: symbol 'ef100_hard_start_xmit' was not declared. Should it be static?
28a27,41
drivers/net/ethernet/sfc/ef100_rx.c:15:6: warning: symbol '__efx_rx_packet' was not declared. Should it be static?
drivers/net/ethernet/sfc/ef100_tx.c:16:5: warning: symbol 'efx_enqueue_skb_tso' was not declared. Should it be static?
drivers/net/ethernet/sfc/ef100_netdev.c:45:13: warning: no previous prototype for ‘ef100_hard_start_xmit’ [-Wmissing-prototypes]
   45 | netdev_tx_t ef100_hard_start_xmit(struct sk_buff *skb,
      |             ^~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/ef100_rx.c:15:6: warning: no previous prototype for ‘__efx_rx_packet’ [-Wmissing-prototypes]
   15 | void __efx_rx_packet(struct efx_channel *channel)
      |      ^~~~~~~~~~~~~~~
drivers/net/ethernet/sfc/ef100_tx.c:16:5: warning: no previous prototype for ‘efx_enqueue_skb_tso’ [-Wmissing-prototypes]
   16 | int efx_enqueue_skb_tso(struct efx_tx_queue *tx_queue, struct sk_buff *skb,
      |     ^~~~~~~~~~~~~~~~~~~