netdev - Re: [PATCH net-next v2 2/4] bnx2x: Populate database for Idlechk tests.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200703.130347.700992704113418218.davem@davemloft.net>
Date:   Fri, 03 Jul 2020 13:03:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     skalluru@...vell.com
Cc:     netdev@...r.kernel.org, aelior@...vell.com, irusskikh@...vell.com,
        mkalderon@...vell.com
Subject: Re: [PATCH net-next v2 2/4] bnx2x: Populate database for Idlechk
 tests.

From: David Miller <davem@...emloft.net>
Date: Fri, 03 Jul 2020 13:03:07 -0700 (PDT)

> From: Sudarsana Reddy Kalluru <skalluru@...vell.com>
> Date: Fri, 3 Jul 2020 17:39:48 +0530
> 
>> +/* struct holding the database of self test checks (registers and predicates) */
>> +/* lines start from 2 since line 1 is heading in csv */
>> +#define ST_DB_LINES 468
>> +struct st_record st_database[ST_DB_LINES] = {
> 
> This will introduce a build warning because there is no external declaration for
> this global variable.
> 
> A patch series must be fully bisectable, meaning that you can't just
> add this declaration in a future patch in the series.  It has to be
> added in the same patch where the symbol is defined.

Actually, looking further, it's even worse.

You mark it global here, and then mark it static in the next patch.

Don't do that please.