netdev - Re: [bpf-next PATCH v2] bpf: fix bpftool without skeleton code enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <613cfcd0-a4e2-d193-6d23-883f27a35a4a@iogearbox.net>
Date:   Fri, 3 Jul 2020 23:22:49 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     John Fastabend <john.fastabend@...il.com>, yhs@...com,
        andriin@...com, ast@...nel.org
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [bpf-next PATCH v2] bpf: fix bpftool without skeleton code
 enabled

On 7/3/20 6:31 AM, John Fastabend wrote:
> Fix segfault from bpftool by adding emit_obj_refs_plain when skeleton
> code is disabled.
> 
> Tested by deleting BUILD_BPF_SKELS in Makefile. We found this doing
> backports for Cilium when a testing image pulled in latest bpf-next
> bpftool, but kept using an older clang-7.
> 
> # ./bpftool prog show
> Error: bpftool built without PID iterator support
> 3: cgroup_skb  tag 7be49e3934a125ba  gpl
>          loaded_at 2020-07-01T08:01:29-0700  uid 0
> Segmentation fault
> 
> Reported-by: Joe Stringer <joe@...d.net.nz>
> Signed-off-by: John Fastabend <john.fastabend@...il.com>
> Acked-by: Yonghong Song <yhs@...com>

Applied, thanks!