netdev - Re: [PATCH net 0/2] net: rmnet: fix interface leak for rmnet module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 02 Jul 2020 22:01:43 -0600
From:   subashab@...eaurora.org
To:     Taehee Yoo <ap420073@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, stranche@...eaurora.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net 0/2] net: rmnet: fix interface leak for rmnet module

On 2020-07-02 11:07, Taehee Yoo wrote:
> There are two problems in rmnet module that they occur the leak of
> a lower interface.
> The symptom is the same, which is the leak of a lower interface.
> But there are two different real problems.
> This patchset is to fix these real problems.
> 
> 1. Do not allow to have different two modes.
> As a lower interface of rmnet, there are two modes that they are VND
> and BRIDGE.
> One interface can have only one mode.
> But in the current rmnet, there is no code to prevent to have
> two modes in one lower interface.
> So, interface leak occurs.
> 
> 2. Do not allow to add multiple bridge interfaces.
> rmnet can have only two bridge interface.
> If an additional bridge interface is tried to be attached,
> rmnet should deny it.
> But there is no code to do that.
> So, interface leak occurs.
> 
> Taehee Yoo (2):
>   net: rmnet: fix lower interface leak
>   net: rmnet: do not allow to add multiple bridge interfaces
> 
>  .../net/ethernet/qualcomm/rmnet/rmnet_config.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)

Thanks Taehee. For the series-

Reviewed-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>