netdev - Re: [PATCH net 2/2] net/sched: act_ct: add miss tcf_lastuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 4 Jul 2020 15:46:04 +0800
From:   wenxu <wenxu@...oud.cn>
To:     netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] net/sched: act_ct: add miss tcf_lastuse_update.

Please drop this one for wrong tags

在 2020/7/4 15:42, wenxu@...oud.cn 写道:
> From: wenxu <wenxu@...oud.cn>
>
> When tcf_ct_act execute the tcf_lastuse_update should
> be update or the used stats never update
>
> filter protocol ip pref 3 flower chain 0
> filter protocol ip pref 3 flower chain 0 handle 0x1
>   eth_type ipv4
>   dst_ip 1.1.1.1
>   ip_flags frag/firstfrag
>   skip_hw
>   not_in_hw
>  action order 1: ct zone 1 nat pipe
>   index 1 ref 1 bind 1 installed 103 sec used 103 sec
>  Action statistics:
>  Sent 151500 bytes 101 pkt (dropped 0, overlimits 0 requeues 0)
>  backlog 0b 0p requeues 0
>  cookie 4519c04dc64a1a295787aab13b6a50fb
>
> Signed-off-by: wenxu <wenxu@...oud.cn>
> ---
>  net/sched/act_ct.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
> index 2eaabdc..ec0250f 100644
> --- a/net/sched/act_ct.c
> +++ b/net/sched/act_ct.c
> @@ -928,6 +928,8 @@ static int tcf_ct_act(struct sk_buff *skb, const struct tc_action *a,
>  	force = p->ct_action & TCA_CT_ACT_FORCE;
>  	tmpl = p->tmpl;
>  
> +	tcf_lastuse_update(&c->tcf_tm);
> +
>  	if (clear) {
>  		ct = nf_ct_get(skb, &ctinfo);
>  		if (ct) {