netdev - Re: [PATCH v2 net-next 5/6] net: dsa: felix: delete .phylink_mac_an

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200704155048.nsrzn4byujvkab3q@skbuf>
Date:   Sat, 4 Jul 2020 18:50:48 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        f.fainelli@...il.com, vivien.didelot@...il.com,
        claudiu.manoil@....com, alexandru.marginean@....com,
        ioana.ciornei@....com
Subject: Re: [PATCH v2 net-next 5/6] net: dsa: felix: delete
 .phylink_mac_an_restart code

On Sat, Jul 04, 2020 at 03:56:14PM +0100, Russell King - ARM Linux admin wrote:

[snip]

> 
> NAK for this description.  You know why.
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Sorry, I cannot work with "too busy" (your feedback from v1) and "you
know why". If there's anything incorrect in the description of the
patch, please point it out and I will change it.

There seems to be a disconnect between what I thought this phylink
callback does (and hence the reason why the code I'm deleting exists)
and what it really does. That disconnect is explained in enough detail
that even somebody who isn't intimately familiar with phylink and/or
clause 37 AN can understand. Then a justification of why deleting this
code is, at least given what we know now, the right thing to do.

I am really not trying to make any more waves than necessary, so please
help me to formulate the description in a way that is acceptable for
merging into the mainline Linux kernel.

-Vladimir