netdev - Re: [PATCH ethtool v4 1/6] Add cable test support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200704234326.renmbb3c52ooak66@lion.mk-sys.cz>
Date:   Sun, 5 Jul 2020 01:43:26 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev <netdev@...r.kernel.org>, Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH ethtool v4 1/6] Add cable test support

On Wed, Jul 01, 2020 at 03:07:38AM +0200, Andrew Lunn wrote:
> Add support for starting a cable test, and report the results.
> 
> This code does not follow the usual patterns because of the way the
> kernel reports the results of the cable test. It can take a number of
> seconds for cable testing to occur. So the action request messages is
> immediately acknowledges, and the test is then performed asynchronous.
> Once the test has completed, the results are returned as a
> notification.
> 
> This means the command starts as usual. It then monitors multicast
> messages until it receives the results.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
[...]
> diff --git a/netlink/monitor.c b/netlink/monitor.c
> index 18d4efd..1af11ee 100644
> --- a/netlink/monitor.c
> +++ b/netlink/monitor.c
> @@ -59,6 +59,10 @@ static struct {
>  		.cmd	= ETHTOOL_MSG_EEE_NTF,
>  		.cb	= eee_reply_cb,
>  	},
> +	{
> +		.cmd	= ETHTOOL_MSG_CABLE_TEST_NTF,
> +		.cb	= cable_test_ntf_cb,
> +	},
>  };
>  

Please add also an entry to monitor_opts[] so that user can use
--cable-test as filter for --monitor.

Looks good otherwise.

Michal