netdev - Re: [PATCH net] hsr: fix interface leak in error path of hsr_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 04 Jul 2020 18:03:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] hsr: fix interface leak in error path of
 hsr_dev_finalize()

From: Taehee Yoo <ap420073@...il.com>
Date: Thu,  2 Jul 2020 17:06:19 +0000

> To release hsr(upper) interface, it should release
> its own lower interfaces first.
> Then, hsr(upper) interface can be released safely.
> In the current code of error path of hsr_dev_finalize(), it releases hsr
> interface before releasing a lower interface.
> So, a warning occurs, which warns about the leak of lower interfaces.
> In order to fix this problem, changing the ordering of the error path of
> hsr_dev_finalize() is needed.
 ...
> Fixes: e0a4b99773d3 ("hsr: use upper/lower device infrastructure")
> Reported-by: syzbot+7f1c020f68dab95aab59@...kaller.appspotmail.com
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied and queued up for v5.7 -stable, thank you.