netdev - Re: [PATCH net-next 2/3] dsa: bcm_sf2: Initialize __be16 with a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 Jul 2020 13:38:12 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/3] dsa: bcm_sf2: Initialize __be16 with a
 __be16 value



On 7/5/2020 1:36 PM, Andrew Lunn wrote:
> A __be16 variable should be initialised with a __be16 value.  So add a
> htons(). In this case it is pointless, given the value being assigned
> is 0xffff, but it stops sparse from warnings.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

The subject should be:

net: dsa: bcm_sf2: Initialize __be16 with a __be16 value

to be consistent with other commits done to the same file, with that:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian