netdev - Re: [PATCH net-next 4/5] net: dsa: tag_mtk: Fix warnings for _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <074021f8-e5a5-ba78-53f3-aaa2777017e4@gmail.com>
Date:   Sun, 5 Jul 2020 13:41:47 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next 4/5] net: dsa: tag_mtk: Fix warnings for __be16



On 7/5/2020 12:30 PM, Andrew Lunn wrote:
> net/dsa/tag_mtk.c:84:13: warning: incorrect type in assignment (different base types)
> net/dsa/tag_mtk.c:84:13:    expected restricted __be16 [usertype] hdr
> net/dsa/tag_mtk.c:84:13:    got int
> net/dsa/tag_mtk.c:94:17: warning: restricted __be16 degrades to integer
> 
> The result of a ntohs() is not __be16, but u16.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian