netdev - Re: [net-next PATCH 4/5 v2] net: dsa: rtl8366: VLAN 0 as disable tagging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb-OLq7d5RViDTyHEA1e0+Jtx26BMnv+ZmE6TL_kBjgzg@mail.gmail.com>
Date:   Mon, 6 Jul 2020 01:04:12 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev <netdev@...r.kernel.org>,
        DENG Qingfang <dqfext@...il.com>,
        Mauri Sandberg <sandberg@...lfence.com>
Subject: Re: [net-next PATCH 4/5 v2] net: dsa: rtl8366: VLAN 0 as disable tagging

On Thu, Jun 18, 2020 at 5:24 AM Florian Fainelli <f.fainelli@...il.com> wrote:
> On 6/17/2020 1:31 AM, Linus Walleij wrote:

> > Make sure that setting VLAN 0 has the same effect
> > and does not try to actually tell the hardware to use
> > VLAN 0 on the port because that will not work.
>
> Why, you are not really describing what happens if VID = 0 is programmed?

OK I'll add some words about it to the commit message.
The packets doesn't go through the switch is the short
answer, I cannot give any better answer I think because,
well, realtek-type documentation (none).

> It also sounds like you should be setting
> configure_vlan_while_not_filtering if you need the switch to be
> configured with VLAN awareness no matter whether there is a bridge
> configured or not.

Oh another thing I didn't know existed, I'll try this,
but it needs to be a separate patch I think, possibly
removing some code for default VLANs.

Thanks!
Linus Walleij