netdev - Re: [PATCH] dsa: rtl8366: Pass GENMASK() signed bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaZ3Hz50wetewiUPYVAe_Lfuz7x_Xy0QLiMQEZnFLcRnQ@mail.gmail.com>
Date:   Mon, 6 Jul 2020 01:17:41 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] dsa: rtl8366: Pass GENMASK() signed bits

On Sun, Jul 5, 2020 at 10:42 PM Andrew Lunn <andrew@...n.ch> wrote:

> Oddly, GENMASK() requires signed bit numbers, so that it can compare
> them for < 0. If passed an unsigned type, we get warnings about the
> test never being true.
>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

I just resent my RTL8366RB series and I picked this patch in
front of the series so as to make sure it applies. (I also took
care to carry forward the same fix in the new code.) I hope there
are no other collisions.

Yours,
Linus Walleij