netdev - Re: [PATCHv2 ipsec-next 09/10] xfrm: interface: support IP6IP6 and IP6IP tunnels processing with .cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_ebOEv-V+GZUtsmmOxsZSK4VKfkD5pHW_9K7ZoK_omFtA@mail.gmail.com>
Date:   Mon, 6 Jul 2020 00:57:48 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     network dev <netdev@...r.kernel.org>, kbuild-all@...ts.01.org,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCHv2 ipsec-next 09/10] xfrm: interface: support IP6IP6 and
 IP6IP tunnels processing with .cb_handler

On Fri, Jul 3, 2020 at 7:55 AM kernel test robot <lkp@...el.com> wrote:
>
> Hi Xin,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on ipsec-next/master]
>
> url:    https://github.com/0day-ci/linux/commits/Xin-Long/xfrm-support-ipip-and-ipv6-tunnels-in-vti-and-xfrmi/20200630-154042
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
> config: x86_64-randconfig-a012-20200701 (attached as .config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce (this is a W=1 build):
>         # save the attached .config to linux build tree
>         make W=1 ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All errors (new ones prefixed by >>):
>
>    ld: net/xfrm/xfrm_interface.o: in function `xfrmi6_rcv_tunnel':
> >> net/xfrm/xfrm_interface.c:807: undefined reference to `xfrm6_tunnel_spi_lookup'
I will add  "#ifdef CONFIG_INET(6)_XFRM_TUNNEL" to fix it in v3.

Thanks.

>
> vim +807 net/xfrm/xfrm_interface.c
>
>    800
>    801  static int xfrmi6_rcv_tunnel(struct sk_buff *skb)
>    802  {
>    803          const xfrm_address_t *saddr;
>    804          __be32 spi;
>    805
>    806          saddr = (const xfrm_address_t *)&ipv6_hdr(skb)->saddr;
>  > 807          spi = xfrm6_tunnel_spi_lookup(dev_net(skb->dev), saddr);
>    808
>    809          return xfrm6_rcv_spi(skb, IPPROTO_IPV6, spi, NULL);
>    810  }
>    811
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org