netdev - Re: [PATCH v2 iproute2-next] devlink: Add board.serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200705110301.20baf5c2@hermes.lan>
Date:   Sun, 5 Jul 2020 11:03:01 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com, davem@...emloft.net,
        jiri@...lanox.com, kuba@...nel.org, michael.chan@...adcom.com
Subject: Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to
 info subcommand.

On Mon, 29 Jun 2020 13:13:04 +0530
Vasundhara Volam <vasundhara-v.volam@...adcom.com> wrote:

> Add support for reading board serial_number to devlink info
> subcommand. Example:
> 
> $ devlink dev info pci/0000:af:00.0 -jp
> {
>     "info": {
>         "pci/0000:af:00.0": {
>             "driver": "bnxt_en",
>             "serial_number": "00-10-18-FF-FE-AD-1A-00",
>             "board.serial_number": "433551F+172300000",
>             "versions": {
>                 "fixed": {
>                     "board.id": "7339763 Rev 0.",
>                     "asic.id": "16D7",
>                     "asic.rev": "1"
>                 },
>                 "running": {
>                     "fw": "216.1.216.0",
>                     "fw.psid": "0.0.0",
>                     "fw.mgmt": "216.1.192.0",
>                     "fw.mgmt.api": "1.10.1",
>                     "fw.ncsi": "0.0.0.0",
>                     "fw.roce": "216.1.16.0"
>                 }
>             }
>         }
>     }
> }

Although this is valid JSON, many JSON style guides do not allow
for periods in property names. This is done so libraries can use
dot notation to reference objects.

Also the encoding of PCI is problematic