netdev - Re: [PATCH net-next 0/3] mptcp: add REUSEADDR/REUSEPORT/V6ONLY setsockopt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200704.175724.1724928333689332249.davem@davemloft.net>
Date:   Sat, 04 Jul 2020 17:57:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net-next 0/3] mptcp: add REUSEADDR/REUSEPORT/V6ONLY
 setsockopt support

From: Florian Westphal <fw@...len.de>
Date: Sun,  5 Jul 2020 01:30:14 +0200

> restarting an mptcp-patched sshd yields following error:
> 
>   sshd: error: Bind to port 22 on 0.0.0.0 failed: Address already in use.
>   sshd: error: setsockopt IPV6_V6ONLY: Operation not supported
>   sshd: error: Bind to port 22 on :: failed: Address already in use.
>   sshd: fatal: Cannot bind any address.
> 
> This series adds support for the needed setsockopts:
> 
> First patch skips the generic SOL_SOCKET handler for MPTCP:
> in mptcp case, the setsockopt needs to alter the tcp socket, not the mptcp
> parent socket.
> 
> Second patch adds minimal SOL_SOCKET support: REUSEPORT and REUSEADDR.
> Rest is still handled by the generic SOL_SOCKET code.
> 
> Last patch adds IPV6ONLY support.  This makes ipv6 work for openssh:
> It creates two listening sockets, before this patch, binding the ipv6
> socket will fail because the port is already bound by the ipv4 one.

Series applied, thanks Florian.