netdev - Re: [PATCH net] ipv6: fib6_select_path can not use out path for nexthop objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d2deb19-3c7d-5db1-23c8-4f8d15594089@gmail.com>
Date:   Mon, 6 Jul 2020 11:34:12 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net
Cc:     brak@...opa.com
Subject: Re: [PATCH net] ipv6: fib6_select_path can not use out path for
 nexthop objects

On 7/6/20 11:19 AM, David Ahern wrote:
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 82cbb46a2a4f..6451ba313506 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -431,7 +431,7 @@ void fib6_select_path(const struct net *net, struct fib6_result *res,
>  	struct fib6_info *sibling, *next_sibling;
>  	struct fib6_info *match = res->f6i;
>  
> -	if ((!match->fib6_nsiblings && !match->nh) || have_oif_match)
> +	if (!match->nh && (!match->fib6_nsiblings || have_oif_match))
>  		goto out;
>  
>  	/* We might have already computed the hash for ICMPv6 errors. In such

of course I notice this after sending the patch. This can actually break
with multipath nexthop objects since it can overwrite the selected path
if done earlier.

DaveM: please drop; will send a v2