netdev - Re: [PATCH iproute2-next v2] lib: fix checking of returned file handle size for cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200706110705.2d5feb99@hermes.lan>
Date:   Mon, 6 Jul 2020 11:07:05 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Dmitry Yakunin <zeil@...dex-team.ru>
Cc:     dsahern@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2] lib: fix checking of returned file
 handle size for cgroup

On Sun,  5 Jul 2020 19:18:12 +0300
Dmitry Yakunin <zeil@...dex-team.ru> wrote:

> Before this patch check is happened only in case when we try to find
> cgroup at cgroup2 mount point.
> 
> v2:
>   - add Fixes line before Signed-off-by (David Ahern)
> 
> Fixes: d5e6ee0dac64 ("ss: introduce cgroup2 cache and helper functions")
> Signed-off-by: Dmitry Yakunin <zeil@...dex-team.ru>
> ---
>  lib/fs.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/fs.c b/lib/fs.c
> index e265fc0..4b90a70 100644
> --- a/lib/fs.c
> +++ b/lib/fs.c
> @@ -148,10 +148,10 @@ __u64 get_cgroup2_id(const char *path)
>  					strerror(errno));
>  			goto out;
>  		}
> -		if (fhp->handle_bytes != sizeof(__u64)) {
> -			fprintf(stderr, "Invalid size of cgroup2 ID\n");
> -			goto out;
> -		}
> +	}
> +	if (fhp->handle_bytes != sizeof(__u64)) {
> +		fprintf(stderr, "Invalid size of cgroup2 ID\n");
> +		goto out;
>  	}
>  
>  	memcpy(cg_id.bytes, fhp->f_handle, sizeof(__u64));

Applied, thanks.