[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACKFLimkfy974T7OPk5vuKq8fL3JHF4yWrr+xMq0EQ5vq6-d+Q@mail.gmail.com>
Date: Mon, 6 Jul 2020 12:00:24 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: David Miller <davem@...emloft.net>, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 6/8] bnxt_en: Implement ethtool -X to set
indirection table.
On Mon, Jul 6, 2020 at 11:52 AM Jakub Kicinski <kuba@...nel.org> wrote:
> Maybe let me just type out what I had in mind:
>
> unsigned int bnxt_max_rss_ring(bp)
> {
> int i, tbl_size, max_ring;
>
> if (!bp->rss_indir_tbl)
> return 0;
>
> max_ring = 0;
> tbl_size = bnxt_get_rxfh_indir_size(dev);
> for (i = 0; i < tbl_size; i++)
> max_ring = max(max_ring, bp->rss_indir_tbl[i]);
>
> return max_ring;
> }
>
> Then:
>
> if (rx_rings != bp->rx_nr_rings) {
> netdev_warn(bp->dev, "Able to reserve only %d out of %d requested RX rings\n",
> rx_rings, bp->rx_nr_rings);
>
> if (netif_is_rxfh_configured(bp->dev) &&
> rx_rings < bnxt_max_rss_ring(bp)) {
> netdev_err(bp->dev, "RSS table entries reverting to default\n");
> bp->dev->priv_flags &= ~IFF_RXFH_CONFIGURED;
> }
> }
OK Got it. You want to reset the RSS map only when absolutely necessary.
Powered by blists - more mailing lists