netdev - Re: [PATCH net-next] geneve: move all configuration under struct geneve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 06 Jul 2020 13:16:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sd@...asysnail.net
Cc:     netdev@...r.kernel.org, sbrivio@...hat.com
Subject: Re: [PATCH net-next] geneve: move all configuration under struct
 geneve_config

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Mon,  6 Jul 2020 17:18:08 +0200

> This patch adds a new structure geneve_config and moves the per-device
> configuration attributes to it, like we already have in VXLAN with
> struct vxlan_config. This ends up being pretty invasive since those
> attributes are used everywhere.
> 
> This allows us to clean up the argument lists for geneve_configure (4
> arguments instead of 8) and geneve_nl2info (5 instead of 9).
> 
> This also reduces the copy-paste of code setting those attributes
> between geneve_configure and geneve_changelink to a single memcpy,
> which would have avoided the bug fixed in commit
> 56c09de347e4 ("geneve: allow changing DF behavior after creation").
> 
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Looks good, applied, thanks.