netdev - Re: [PATCH ipsec] xfrm: esp6: fix encapsulation header offset computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21c4da93-03be-efc8-ee9e-310504813bfe@strongswan.org>
Date:   Mon, 6 Jul 2020 10:09:13 +0200
From:   Tobias Brunner <tobias@...ongswan.org>
To:     Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org
Cc:     steffen.klassert@...unet.com
Subject: Re: [PATCH ipsec] xfrm: esp6: fix encapsulation header offset
 computation

Hi Sabrina,

> In commit 0146dca70b87, I incorrectly adapted the code that computes
> the location of the UDP or TCP encapsulation header from IPv4 to
> IPv6. In esp6_input_done2, skb->transport_header points to the ESP
> header, so by adding skb_network_header_len, uh and th will point to
> the ESP header, not the encapsulation header that's in front of it.
> 
> Since the TCP header's size can change with options, we have to start
> from the IPv6 header and walk past possible extensions.
> 
> Fixes: 0146dca70b87 ("xfrm: add support for UDPv6 encapsulation of ESP")
> Fixes: 26333c37fc28 ("xfrm: add IPv6 support for espintcp")
> Reported-by: Tobias Brunner <tobias@...ongswan.org>
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks for the fix!

Tested-by: Tobias Brunner <tobias@...ongswan.org>

Regards,
Tobias