netdev - Re: [PATCH] amd-xgbe: add module param for auto negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 00:31:25 +0530
From:   Shyam Sundar S K <ssundark@....com>
To:     Andrew Lunn <andrew@...n.ch>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>
Cc:     Tom Lendacky <thomas.lendacky@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH] amd-xgbe: add module param for auto negotiation

On 7/7/2020 11:25 PM, Andrew Lunn wrote:
> [CAUTION: External Email]
>
> On Tue, Jul 07, 2020 at 05:32:54PM +0000, Shyam Sundar S K wrote:
>> In embedded environments, ethtool may not be available to toggle between
>> auto negotiation on/off.
>>
>> Add a module parameter to control auto negotiation for these situations.
Hi Andrew
> Where does this end? You can set the link speed via module parameters?
> Pause? Duplex?
>
>         Andrew

Agree to your feedback. Most of the information required to control the 
connection is already present in the

driver and this piece of information is missing. Customers who run a 
minimal Linux do not have the flexibility

to add userspace applications like ethtool to control the connection 
information. Please consider this as expectional

case, or else I would not have proposed this change.

Thanks,

Shyam