netdev - Re: [PATCH net-next] sun/cassini: mark cas_resume() as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Jul 2020 13:00:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiyongjun1@...wei.com
Cc:     hulkci@...wei.com, kuba@...nel.org, hkallweit1@...il.com,
        leon@...nel.org, mhabets@...arflare.com, wu000273@....edu,
        mst@...hat.com, keescook@...omium.org, vaibhavgupta40@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sun/cassini: mark cas_resume() as
 __maybe_unused

From: Wei Yongjun <weiyongjun1@...wei.com>
Date: Tue, 7 Jul 2020 18:55:43 +0800

> In certain configurations without power management support, gcc report
> the following warning:
> 
> drivers/net/ethernet/sun/cassini.c:5206:12: warning:
>  'cas_resume' defined but not used [-Wunused-function]
>  5206 | static int cas_resume(struct device *dev_d)
>       |            ^~~~~~~~~~
> 
> Mark cas_resume() as __maybe_unused to make it clear.
> 
> Fixes: f193f4ebde3d ("sun/cassini: use generic power management")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied, thanks.