netdev - Re: [PATCH net] ipv6: Fix use of anycast address with loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Jul 2020 13:04:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, thomas.gambier@...edi.com
Subject: Re: [PATCH net] ipv6: Fix use of anycast address with loopback

From: David Ahern <dsahern@...nel.org>
Date: Tue,  7 Jul 2020 07:39:24 -0600

> Thomas reported a regression with IPv6 and anycast using the following
> reproducer:
> 
>     echo 1 >  /proc/sys/net/ipv6/conf/all/forwarding
>     ip -6 a add fc12::1/16 dev lo
>     sleep 2
>     echo "pinging lo"
>     ping6 -c 2 fc12::
> 
> The conversion of addrconf_f6i_alloc to use ip6_route_info_create missed
> the use of fib6_is_reject which checks addresses added to the loopback
> interface and sets the REJECT flag as needed. Update fib6_is_reject for
> loopback checks to handle RTF_ANYCAST addresses.
> 
> Fixes: c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use ip6_route_info_create")
> Reported-by: thomas.gambier@...edi.com
> Signed-off-by: David Ahern <dsahern@...nel.org>

Applied, and queued up for -stable, thanks David.