netdev - Re: [pull request][net 00/11] mlx5 fixes 2020-07-02

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Jul 2020 13:33:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [pull request][net 00/11] mlx5 fixes 2020-07-02

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Thu,  2 Jul 2020 15:19:12 -0700

> This series introduces some fixes to mlx5 driver.
> 
> Please pull and let me know if there is any problem.

This needs more work.

I agree with Jakub that duplicating standard stats in ethtool -S is
and has always been a very bad idea.  We let people get away with it
initially in order to allow per-queue stats, but that was a mistake
and even if it was the right way forward it doesn't mean the rest of
the ip -s stats should have been duplicated as well.

Jakub's base argument is true, if we ever do something better in the
generic 'ip -s' stuff it will not propagate to all of the 'ethtool -S'
because it is duplicated around in every driver.

We let driver developers get away with a lot with ethtool custom
statistics and we're past due to perform some push back on this issue.

There also seems to be some necessary discussion about where the tc
reference count fix really belongs.