[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jul 2020 19:28:45 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc: netdev <netdev@...r.kernel.org>,
Heiner Kallweit <hkallweit1@...il.com>,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v2 1/7] net: phy: at803x: Avoid comparison is
always false warning
On 7/6/2020 6:49 PM, Andrew Lunn wrote:
> By placing the GENMASK value into an unsigned int and then passing it
> to PREF_FIELD, the type is reduces down from ULL. Given the reduced
> size of the type, the range checks in PREP_FAIL() are always true, and
> -Wtype-limits then gives a warning.
>
> By skipping the intermediate variable, the warning can be avoided.
>
> Reviewed-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
Reviwed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists