netdev - Re: [PATCH v2 0/2] smsc: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200707.152217.580419867258219789.davem@davemloft.net>
Date:   Tue, 07 Jul 2020 15:22:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vaibhavgupta40@...il.com
Cc:     helgaas@...nel.org, bhelgaas@...gle.com, bjorn@...gaas.com,
        vaibhav.varodek@...il.com, kuba@...nel.org,
        steve.glendinning@...well.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        skhan@...uxfoundation.org
Subject: Re: [PATCH v2 0/2] smsc: use generic power management

From: Vaibhav Gupta <vaibhavgupta40@...il.com>
Date: Fri,  3 Jul 2020 08:31:36 +0530

> Linux Kernel Mentee: Remove Legacy Power Management.
> 
> The purpose of this patch series is to remove legacy power management callbacks
> from smsc ethernet drivers.
> 
> The callbacks performing suspend() and resume() operations are still calling
> pci_save_state(), pci_set_power_state(), etc. and handling the power management
> themselves, which is not recommended.
> 
> The conversion requires the removal of the those function calls and change the
> callback definition accordingly and make use of dev_pm_ops structure.
> 
> All patches are compile-tested only.
> 
> V2: Kbuild in V1, warning: variable 'err' is used uninitialized whenever 'if'
> conditio is false in funcution .resume() .

Series applied to net-next, thanks.