netdev - Re: [PATCH net] mptcp: fix DSS map generation on fin retransmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Jul 2020 15:28:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: fix DSS map generation on fin retransmission

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri,  3 Jul 2020 18:06:04 +0200

> The RFC 8684 mandates that no-data DATA FIN packets should carry
> a DSS with 0 sequence number and data len equal to 1. Currently,
> on FIN retransmission we re-use the existing mapping; if the previous
> fin transmission was part of a partially acked data packet, we could
> end-up writing in the egress packet a non-compliant DSS.
> 
> The above will be detected by a "Bad mapping" warning on the receiver
> side.
> 
> This change addresses the issue explicitly checking for 0 len packet
> when adding the DATA_FIN option.
> 
> Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data packets")
> Reported-by: syzbot+42a07faa5923cfaeb9c9@...kaller.appspotmail.com
> Tested-by: Christoph Paasch <cpaasch@...le.com>
> Reviewed-by: Christoph Paasch <cpaasch@...le.com>
> Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied and queued up for -stable, thank you.