netdev - Re: [PATCH net-next] net: phy: add a Kconfig option for mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 07 Jul 2020 15:37:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brgl@...ev.pl
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        linux@...linux.org.uk, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bgolaszewski@...libre.com,
        lkp@...el.com
Subject: Re: [PATCH net-next] net: phy: add a Kconfig option for mdio_devres

From: Bartosz Golaszewski <brgl@...ev.pl>
Date: Sun,  5 Jul 2020 11:55:47 +0200

> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> If phylib is built as a module and CONFIG_MDIO_DEVICE is 'y', the
> mdio_device and mdio_bus code will be in the phylib module, not in the
> kernel image. Meanwhile we build mdio_devres depending on the
> CONFIG_MDIO_DEVICE symbol, so if it's 'y', it will go into the kernel
> and we'll hit the following linker error:
> 
>    ld: drivers/net/phy/mdio_devres.o: in function `devm_mdiobus_alloc_size':
>>> drivers/net/phy/mdio_devres.c:38: undefined reference to `mdiobus_alloc_size'
>    ld: drivers/net/phy/mdio_devres.o: in function `devm_mdiobus_free':
>>> drivers/net/phy/mdio_devres.c:16: undefined reference to `mdiobus_free'
>    ld: drivers/net/phy/mdio_devres.o: in function `__devm_mdiobus_register':
>>> drivers/net/phy/mdio_devres.c:87: undefined reference to `__mdiobus_register'
>    ld: drivers/net/phy/mdio_devres.o: in function `devm_mdiobus_unregister':
>>> drivers/net/phy/mdio_devres.c:53: undefined reference to `mdiobus_unregister'
>    ld: drivers/net/phy/mdio_devres.o: in function `devm_of_mdiobus_register':
>>> drivers/net/phy/mdio_devres.c:120: undefined reference to `of_mdiobus_register'
> 
> Add a hidden Kconfig option for MDIO_DEVRES which will be currently
> selected by CONFIG_PHYLIB as there are no non-phylib users of these
> helpers.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: ac3a68d56651 ("net: phy: don't abuse devres in devm_mdiobus_register()")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>

Applied, thank you.