netdev - Re: [PATCH net-next v2] net: sfp: Unique GPIO interrupt names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 02:40:34 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Healy <cphealy@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, kuba@...nel.org,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        netdev <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net: sfp: Unique GPIO interrupt names

> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index 73c2969f11a4..193a124c26c4 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -2239,6 +2239,7 @@ static int sfp_probe(struct platform_device *pdev)
>      const struct sff_data *sff;
>      struct i2c_adapter *i2c;
>      struct sfp *sfp;
> +    char *sfp_irq_name;
>      int err, i;

Hi Chris

Reverse Christmas tree.

> 
>      sfp = sfp_alloc(&pdev->dev);
> @@ -2349,12 +2350,16 @@ static int sfp_probe(struct platform_device *pdev)
>              continue;
>          }
> 
> +        sfp_irq_name = devm_kasprintf(sfp->dev, GFP_KERNEL,
> +                          "%s-%s", dev_name(sfp->dev),
> +                          gpio_of_names[i]);
> +

Did you run ./scripts/checkpatch.pl on this patch? I suspect it will
complain about spaces, not tabs.

Humm, actually, all tabs seem to of been converted to spaces.

Something David often recommends. email the patch to yourself, and
then apply it using git am. If it does not apply cleanly, something
has mangled it.

    Andrew